WW-5391 Add interface for VelocityManager extension point #867
Conversation
|
|
||
| public void setVelocityManager(VelocityManagerInterface vmi) { | ||
| LOG.trace("OSGi ConfigurationProvider - setVelocityManager() called - VelocityManager: [{}]", vmi); | ||
| if (!(vmi instanceof VelocityManager)) { |
There was a problem hiding this comment.
Didn't bother with a marker interface here as this plugin is deprecated anyway
There was a problem hiding this comment.
Standardised line endings to LF
| /** | ||
| * @since 6.4.0 | ||
| */ | ||
| public interface VelocityManagerInterface { |
There was a problem hiding this comment.
Maybe in 7.0 we can consider renaming VelocityManager to StrutsVelocityManager and VelocityManagerInterface to VelocityManager
|
@lukaszlenart Sonar results don't make any sense, it's been misconfigured ever since the 7.0 branch was introduced |
|
Should be fixed |
|
@lukaszlenart Thanks! Looks like it's just complaining about deprecations, serialisation and code coverage. I've fixed the serialisation warnings. The code coverage I don't think it makes sense for me to rectify as I've just done a find and replace on injection methods. Adding coverage to those injection methods alone won't add much value, and it's out of scope for me to add coverage to the whole class. |
|
WW-5391
Allows applications to provide a completely custom VelocityManager